#6: implement IMAP IDLE (RFC 2177) and CONDSTORE (RFC 7162)

This commit is contained in:
Lucas Rayan committed 2026-07-24 11:43:37 -03:00
1 parent 0ec0698079
commit 6b1e4dc00a
20 files changed
+526 -82

No files matched your search

@@ -87,6 +87,7 @@ func main() {
expungeRepo := postgres.NewExpungeRepository(pool) expungeRepo := postgres.NewExpungeRepository(pool)
copyRepo := postgres.NewCopyRepository(pool) copyRepo := postgres.NewCopyRepository(pool)
imapUseCase := usecase.NewImapSessionUseCase(authRepo, imapFolders, messageQuery, flagRepo, blobReader, expungeRepo, copyRepo) imapUseCase := usecase.NewImapSessionUseCase(authRepo, imapFolders, messageQuery, flagRepo, blobReader, expungeRepo, copyRepo)
useCase.SetTrackerManager(imapUseCase.GetTrackerManager(), imapFolders)
imapServer := imapserver.New(&imapserver.Options{ imapServer := imapserver.New(&imapserver.Options{
NewSession: func(c *imapserver.Conn) (imapserver.Session, *imapserver.GreetingData, error) { NewSession: func(c *imapserver.Conn) (imapserver.Session, *imapserver.GreetingData, error) {
@@ -96,6 +97,8 @@ func main() {
imap.CapIMAP4rev1: {}, imap.CapIMAP4rev1: {},
imap.CapMove: {}, imap.CapMove: {},
imap.CapUIDPlus: {}, imap.CapUIDPlus: {},
imap.CapIdle: {},
imap.CapCondStore: {},
}, },
TLSConfig: &tls.Config{GetCertificate: certProvider.GetCertificate, MinVersion: tls.VersionTLS12}, TLSConfig: &tls.Config{GetCertificate: certProvider.GetCertificate, MinVersion: tls.VersionTLS12},
InsecureAuth: false, InsecureAuth: false,
@@ -16,6 +16,8 @@ const (
type FlagRepository interface { type FlagRepository interface {
// SetFlags applies op with flags to the message identified by // SetFlags applies op with flags to the message identified by
// (folderID, uid). Add/Del insert/delete individual message_flags rows; // (folderID, uid). Add/Del insert/delete individual message_flags rows;
// Set replaces the message's full flag set in one transaction. // Set replaces the message's full flag set in one transaction. If
SetFlags(ctx context.Context, folderID string, uid uint32, op FlagOp, flags []string) error // unchangedSince > 0 and the message's current modseq exceeds it, the update
// is skipped and updated returns false.
SetFlags(ctx context.Context, folderID string, uid uint32, op FlagOp, flags []string, unchangedSince uint64) (updated bool, err error)
} }
@@ -9,6 +9,7 @@ type ImapFolderRecord struct {
UIDNext uint32 UIDNext uint32
UIDValidity uint32 UIDValidity uint32
NumMessages uint32 NumMessages uint32
HighestModSeq uint64
} }
// ImapFolderRepository resolves a mailbox's folders for LIST and SELECT. // ImapFolderRepository resolves a mailbox's folders for LIST and SELECT.
@@ -14,6 +14,7 @@ type MessageRecord struct {
SizeBytes int64 SizeBytes int64
ReceivedAt time.Time ReceivedAt time.Time
Flags []string Flags []string
ModSeq uint64
} }
// MessageQueryRepository lists a folder's messages for FETCH. // MessageQueryRepository lists a folder's messages for FETCH.
@@ -30,10 +30,30 @@ type ImapSessionUseCase struct {
blobs port.BlobReader blobs port.BlobReader
expunger port.ExpungeRepository expunger port.ExpungeRepository
copier port.CopyRepository copier port.CopyRepository
trackerManager *MailboxTrackerManager
} }
func NewImapSessionUseCase(auth port.AuthRepository, folders port.ImapFolderRepository, messages port.MessageQueryRepository, flags port.FlagRepository, blobs port.BlobReader, expunger port.ExpungeRepository, copier port.CopyRepository) *ImapSessionUseCase { func NewImapSessionUseCase(auth port.AuthRepository, folders port.ImapFolderRepository, messages port.MessageQueryRepository, flags port.FlagRepository, blobs port.BlobReader, expunger port.ExpungeRepository, copier port.CopyRepository) *ImapSessionUseCase {
return &ImapSessionUseCase{auth: auth, folders: folders, messages: messages, flags: flags, blobs: blobs, expunger: expunger, copier: copier} return &ImapSessionUseCase{
auth: auth,
folders: folders,
messages: messages,
flags: flags,
blobs: blobs,
expunger: expunger,
copier: copier,
trackerManager: NewMailboxTrackerManager(),
}
}
func (uc *ImapSessionUseCase) SetTrackerManager(tm *MailboxTrackerManager) {
if tm != nil {
uc.trackerManager = tm
}
}
func (uc *ImapSessionUseCase) GetTrackerManager() *MailboxTrackerManager {
return uc.trackerManager
} }
func (uc *ImapSessionUseCase) Login(ctx context.Context, address, password string) (string, error) { func (uc *ImapSessionUseCase) Login(ctx context.Context, address, password string) (string, error) {
@@ -77,8 +97,8 @@ func (uc *ImapSessionUseCase) ReadBlob(ctx context.Context, blobID uuid.UUID) ([
return uc.blobs.ReadByID(ctx, blobID) return uc.blobs.ReadByID(ctx, blobID)
} }
func (uc *ImapSessionUseCase) SetFlags(ctx context.Context, folderID string, uid uint32, op port.FlagOp, flags []string) error { func (uc *ImapSessionUseCase) SetFlags(ctx context.Context, folderID string, uid uint32, op port.FlagOp, flags []string, unchangedSince uint64) (bool, error) {
return uc.flags.SetFlags(ctx, folderID, uid, op, flags) return uc.flags.SetFlags(ctx, folderID, uid, op, flags, unchangedSince)
} }
func (uc *ImapSessionUseCase) Expunge(ctx context.Context, folderID string, uids []uint32) error { func (uc *ImapSessionUseCase) Expunge(ctx context.Context, folderID string, uids []uint32) error {
@@ -149,6 +149,32 @@ func TestImapSessionUseCase_Expunge_DelegatesToRepository(t *testing.T) {
} }
} }
type fakeFlagRepository struct {
lastFolderID string
lastUID uint32
lastOp port.FlagOp
lastFlags []string
lastUnchangedSince uint64
}
func (f *fakeFlagRepository) SetFlags(_ context.Context, folderID string, uid uint32, op port.FlagOp, flags []string, unchangedSince uint64) (bool, error) {
f.lastFolderID, f.lastUID, f.lastOp, f.lastFlags, f.lastUnchangedSince = folderID, uid, op, flags, unchangedSince
return true, nil
}
func TestImapSessionUseCase_SetFlags_DelegatesToRepository(t *testing.T) {
flagRepo := &fakeFlagRepository{}
uc := NewImapSessionUseCase(nil, nil, nil, flagRepo, nil, nil, nil)
updated, err := uc.SetFlags(context.Background(), "folder-1", 7, port.FlagOpAdd, []string{"\\Seen"}, 10)
if err != nil || !updated {
t.Fatalf("SetFlags error: %v, updated=%v", err, updated)
}
if flagRepo.lastFolderID != "folder-1" || flagRepo.lastUID != 7 || flagRepo.lastUnchangedSince != 10 {
t.Errorf("flagRepo state = %+v, want folder-1 uid 7 unchangedSince 10", flagRepo)
}
}
func TestImapSessionUseCase_CopyMessages_ReturnsRepositoryResult(t *testing.T) { func TestImapSessionUseCase_CopyMessages_ReturnsRepositoryResult(t *testing.T) {
copier := &fakeCopyRepository{result: []port.CopiedMessage{{SourceUID: 3, DestUID: 1}, {SourceUID: 7, DestUID: 2}}} copier := &fakeCopyRepository{result: []port.CopiedMessage{{SourceUID: 3, DestUID: 1}, {SourceUID: 7, DestUID: 2}}}
uc := NewImapSessionUseCase(nil, nil, nil, nil, nil, nil, copier) uc := NewImapSessionUseCase(nil, nil, nil, nil, nil, nil, copier)
@@ -0,0 +1,72 @@
package usecase
import (
"sync"
"github.com/emersion/go-imap/v2"
"github.com/emersion/go-imap/v2/imapserver"
)
// MailboxTrackerManager maintains imapserver.MailboxTracker instances per folder ID.
// This allows active IMAP sessions to receive real-time notifications when emails arrive,
// flags change, or messages are expunged (IDLE / RFC 2177).
type MailboxTrackerManager struct {
mu sync.RWMutex
trackers map[string]*imapserver.MailboxTracker
}
func NewMailboxTrackerManager() *MailboxTrackerManager {
return &MailboxTrackerManager{
trackers: make(map[string]*imapserver.MailboxTracker),
}
}
// GetTracker retrieves or initializes the MailboxTracker for folderID.
func (m *MailboxTrackerManager) GetTracker(folderID string, initialNumMessages uint32) *imapserver.MailboxTracker {
m.mu.Lock()
defer m.mu.Unlock()
tracker, ok := m.trackers[folderID]
if !ok {
tracker = imapserver.NewMailboxTracker(initialNumMessages)
m.trackers[folderID] = tracker
}
return tracker
}
// NotifyNumMessages informs all sessions watching folderID of a new EXISTS count.
func (m *MailboxTrackerManager) NotifyNumMessages(folderID string, n uint32) {
m.mu.RLock()
tracker, ok := m.trackers[folderID]
m.mu.RUnlock()
if ok {
tracker.QueueNumMessages(n)
}
}
// NotifyMessageFlags informs sessions watching folderID of updated flags on a message.
func (m *MailboxTrackerManager) NotifyMessageFlags(folderID string, seqNum uint32, uid uint32, flags []string, source *imapserver.SessionTracker) {
m.mu.RLock()
tracker, ok := m.trackers[folderID]
m.mu.RUnlock()
if ok {
imapFlags := make([]imap.Flag, len(flags))
for i, f := range flags {
imapFlags[i] = imap.Flag(f)
}
tracker.QueueMessageFlags(seqNum, imap.UID(uid), imapFlags, source)
}
}
// NotifyExpunge informs sessions watching folderID that seqNum was expunged.
func (m *MailboxTrackerManager) NotifyExpunge(folderID string, seqNum uint32) {
m.mu.RLock()
tracker, ok := m.trackers[folderID]
m.mu.RUnlock()
if ok {
tracker.QueueExpunge(seqNum)
}
}
@@ -39,12 +39,19 @@ type ProcessInboundEmailUseCase struct {
mailboxes port.MailboxRepository mailboxes port.MailboxRepository
blobs port.BlobStorage blobs port.BlobStorage
messages port.InboundMessageRepository messages port.InboundMessageRepository
folders port.ImapFolderRepository
trackerManager *MailboxTrackerManager
} }
func NewProcessInboundEmailUseCase(mailboxes port.MailboxRepository, blobs port.BlobStorage, messages port.InboundMessageRepository) *ProcessInboundEmailUseCase { func NewProcessInboundEmailUseCase(mailboxes port.MailboxRepository, blobs port.BlobStorage, messages port.InboundMessageRepository) *ProcessInboundEmailUseCase {
return &ProcessInboundEmailUseCase{mailboxes: mailboxes, blobs: blobs, messages: messages} return &ProcessInboundEmailUseCase{mailboxes: mailboxes, blobs: blobs, messages: messages}
} }
func (uc *ProcessInboundEmailUseCase) SetTrackerManager(tm *MailboxTrackerManager, folders port.ImapFolderRepository) {
uc.trackerManager = tm
uc.folders = folders
}
// ResolveRecipient is called from the SMTP session's RCPT TO handler. It // ResolveRecipient is called from the SMTP session's RCPT TO handler. It
// returns every mailbox address should be delivered to (more than one for // returns every mailbox address should be delivered to (more than one for
// an alias that fans out), or ErrRecipientNotFound / ErrMailboxQuotaExceeded. // an alias that fans out), or ErrRecipientNotFound / ErrMailboxQuotaExceeded.
@@ -88,6 +95,13 @@ func (uc *ProcessInboundEmailUseCase) Handle(ctx context.Context, input ProcessI
if err != nil { if err != nil {
return err return err
} }
if uc.trackerManager != nil && uc.folders != nil {
folderRec, err := uc.folders.FindByName(ctx, recipient.ID.String(), "INBOX")
if err == nil && folderRec != nil {
uc.trackerManager.NotifyNumMessages(folderRec.ID, folderRec.NumMessages)
}
}
} }
return nil return nil
} }
@@ -0,0 +1,213 @@
package e2e
import (
"bytes"
"context"
"net"
"os"
"path/filepath"
"testing"
"time"
"github.com/alexedwards/argon2id"
embeddedpostgres "github.com/fergusstrange/embedded-postgres"
"github.com/emersion/go-imap/v2"
"github.com/emersion/go-imap/v2/imapclient"
"github.com/emersion/go-imap/v2/imapserver"
appusecase "lambdamail/protocols/internal/application/usecase"
"lambdamail/protocols/internal/application/port"
"lambdamail/protocols/internal/infrastructure/diskstorage"
"lambdamail/protocols/internal/infrastructure/postgres"
imappresentation "lambdamail/protocols/internal/presentation/imap"
)
func TestImapIdleAndCondStoreEndToEnd(t *testing.T) {
if testing.Short() {
t.Skip("e2e test skipped in -short mode")
}
ctx := context.Background()
runtimeDir := t.TempDir()
pg := embeddedpostgres.NewDatabase(embeddedpostgres.DefaultConfig().
Port(54331). // distinct port for concurrent e2e test execution
RuntimePath(runtimeDir).
StartTimeout(120 * time.Second))
if err := pg.Start(); err != nil {
t.Fatalf("start embedded postgres: %v", err)
}
defer pg.Stop()
dbURL := "postgres://postgres:postgres@localhost:54331/postgres?sslmode=disable"
pool, err := postgres.NewPool(ctx, dbURL)
if err != nil {
t.Fatalf("connect: %v", err)
}
defer pool.Close()
root := repoRoot(t)
sql, err := os.ReadFile(filepath.Join(root, "migrations", "0001_init_schema.up.sql"))
if err != nil {
t.Fatalf("read migration: %v", err)
}
if _, err := pool.Exec(ctx, string(sql)); err != nil {
t.Fatalf("apply migration: %v", err)
}
// --- Seed mailbox --------------------------------------------------------
password := "correct horse battery staple"
hash, err := argon2id.CreateHash(password, argon2id.DefaultParams)
if err != nil {
t.Fatalf("hash password: %v", err)
}
domainID := "00000000-0000-0000-0000-000000000001"
mailboxID := "00000000-0000-0000-0000-000000000002"
folderID := "00000000-0000-0000-0000-000000000003"
if _, err := pool.Exec(ctx, `INSERT INTO domains (id, name, punycode_name) VALUES ($1, 'example.test', 'example.test')`, domainID); err != nil {
t.Fatalf("seed domain: %v", err)
}
if _, err := pool.Exec(ctx, `INSERT INTO mailboxes (id, domain_id, local_part, email_address, password_hash) VALUES ($1, $2, 'user', 'user@example.test', $3)`, mailboxID, domainID, hash); err != nil {
t.Fatalf("seed mailbox: %v", err)
}
if _, err := pool.Exec(ctx, `INSERT INTO folders (id, mailbox_id, name, special_use) VALUES ($1, $2, 'INBOX', 'inbox')`, folderID, mailboxID); err != nil {
t.Fatalf("seed folder: %v", err)
}
spool := t.TempDir()
mailboxRepo := postgres.NewMailboxRepository(pool)
inboundUC := appusecase.NewProcessInboundEmailUseCase(
mailboxRepo,
diskstorage.NewLocalDiskBlobStorage(pool, spool),
postgres.NewInboundMessageRepository(pool),
)
imapFolderRepo := postgres.NewImapFolderRepository(pool)
imapUC := appusecase.NewImapSessionUseCase(
postgres.NewAuthRepository(pool),
imapFolderRepo,
postgres.NewMessageQueryRepository(pool),
postgres.NewFlagRepository(pool),
diskstorage.NewLocalDiskBlobReader(pool),
postgres.NewExpungeRepository(pool),
postgres.NewCopyRepository(pool),
)
inboundUC.SetTrackerManager(imapUC.GetTrackerManager(), imapFolderRepo)
server := imapserver.New(&imapserver.Options{
NewSession: func(c *imapserver.Conn) (imapserver.Session, *imapserver.GreetingData, error) {
return imappresentation.NewSession(c, imapUC)
},
Caps: imap.CapSet{
imap.CapIMAP4rev1: {},
imap.CapMove: {},
imap.CapUIDPlus: {},
imap.CapIdle: {},
imap.CapCondStore: {},
},
InsecureAuth: true,
})
ln, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatalf("listen: %v", err)
}
go server.Serve(ln)
defer server.Close()
// Deliver 1 initial message
recipientRecord, err := mailboxRepo.FindActiveByAddress(ctx, "user@example.test")
if err != nil || recipientRecord == nil {
t.Fatalf("find recipient record: %v", err)
}
testMessage := "From: sender@remote.example\r\nTo: user@example.test\r\nSubject: condstore test\r\n\r\nInitial email.\r\n"
if err := inboundUC.Handle(ctx, appusecase.ProcessInboundEmailInput{
Sender: "sender@remote.example",
Recipients: []port.MailboxRecord{*recipientRecord},
RecipientAddresses: []string{"user@example.test"},
Body: bytes.NewBufferString(testMessage),
}); err != nil {
t.Fatalf("seed message: %v", err)
}
// Connect Client A with UnilateralDataHandler to receive live IDLE updates
mailboxUpdates := make(chan *imapclient.UnilateralDataMailbox, 10)
clientOptions := &imapclient.Options{
UnilateralDataHandler: &imapclient.UnilateralDataHandler{
Mailbox: func(data *imapclient.UnilateralDataMailbox) {
mailboxUpdates <- data
},
},
}
clientA, err := imapclient.DialInsecure(ln.Addr().String(), clientOptions)
if err != nil {
t.Fatalf("dial clientA: %v", err)
}
defer clientA.Close()
if err := clientA.Login("user@example.test", password).Wait(); err != nil {
t.Fatalf("LOGIN clientA: %v", err)
}
selectData, err := clientA.Select("INBOX", nil).Wait()
if err != nil {
t.Fatalf("SELECT INBOX: %v", err)
}
if selectData.NumMessages != 1 {
t.Fatalf("expected NumMessages=1, got %d", selectData.NumMessages)
}
// FETCH message 1
fetchItems, err := clientA.Fetch(imap.SeqSetNum(1), &imap.FetchOptions{Flags: true, UID: true}).Collect()
if err != nil {
t.Fatalf("FETCH message 1: %v", err)
}
if len(fetchItems) != 1 {
t.Fatalf("expected 1 fetch item, got %d", len(fetchItems))
}
// STORE flag on message 1
if err := clientA.Store(imap.SeqSetNum(1), &imap.StoreFlags{Op: imap.StoreFlagsAdd, Flags: []imap.Flag{imap.FlagFlagged}}, nil).Close(); err != nil {
t.Fatalf("STORE flag failed: %v", err)
}
// SEARCH test by flag
searchRes, err := clientA.Search(&imap.SearchCriteria{Flag: []imap.Flag{imap.FlagFlagged}}, nil).Wait()
if err != nil {
t.Fatalf("SEARCH FLAGGED: %v", err)
}
if searchRes.Count != 1 {
t.Fatalf("SEARCH FLAGGED expected 1 result, got %d", searchRes.Count)
}
// --- IDLE test -----------------------------------------------------------
idleCmd, err := clientA.Idle()
if err != nil {
t.Fatalf("start IDLE: %v", err)
}
// Concurrently deliver a 2nd message while clientA is IDLE
newMessage := "From: sender2@remote.example\r\nTo: user@example.test\r\nSubject: idle update\r\n\r\nRealtime email.\r\n"
go func() {
time.Sleep(100 * time.Millisecond)
_ = inboundUC.Handle(context.Background(), appusecase.ProcessInboundEmailInput{
Sender: "sender2@remote.example",
Recipients: []port.MailboxRecord{*recipientRecord},
RecipientAddresses: []string{"user@example.test"},
Body: bytes.NewBufferString(newMessage),
})
}()
// Wait for clientA to receive mailbox update notification via UnilateralDataHandler
select {
case update := <-mailboxUpdates:
if update == nil || update.NumMessages == nil || *update.NumMessages != 2 {
t.Fatalf("expected update.NumMessages=2, got %+v", update)
}
case <-time.After(3 * time.Second):
t.Fatal("timed out waiting for IDLE notification")
}
if err := idleCmd.Close(); err != nil {
t.Fatalf("close IDLE: %v", err)
}
}
@@ -72,8 +72,9 @@ func (r *CopyRepository) copyOne(ctx context.Context, sourceFolderID string, sou
} }
destUID := uint32(destUIDNext) destUID := uint32(destUIDNext)
if _, err := tx.Exec(ctx, `UPDATE folders SET uid_next = uid_next + 1, total_count = total_count + 1 WHERE id = $1`, destFolderID); err != nil { var destModSeq int64
return 0, fmt.Errorf("advance destination uid_next: %w", err) if err := tx.QueryRow(ctx, `UPDATE folders SET uid_next = uid_next + 1, highest_modseq = highest_modseq + 1, total_count = total_count + 1 WHERE id = $1 RETURNING highest_modseq`, destFolderID).Scan(&destModSeq); err != nil {
return 0, fmt.Errorf("advance destination uid_next and highest_modseq: %w", err)
} }
var wasSeen bool var wasSeen bool
@@ -97,14 +98,14 @@ func (r *CopyRepository) copyOne(ctx context.Context, sourceFolderID string, sou
var destReceivedAt any var destReceivedAt any
err = tx.QueryRow(ctx, ` err = tx.QueryRow(ctx, `
INSERT INTO email_messages ( INSERT INTO email_messages (
mailbox_id, folder_id, uid, blob_id, mailbox_id, folder_id, uid, modseq, blob_id,
sender_address, recipient_addresses, size_bytes, sender_address, recipient_addresses, size_bytes,
spf_result, dkim_result, dmarc_result, spf_result, dkim_result, dmarc_result,
from_display_name, subject, snippet, message_id_header, in_reply_to, thread_id, has_attachments, from_display_name, subject, snippet, message_id_header, in_reply_to, thread_id, has_attachments,
arc_result, dane_status, tls_version, spam_score, spam_verdict, virus_name arc_result, dane_status, tls_version, spam_score, spam_verdict, virus_name
) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21, $22, $23) ) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20, $21, $22, $23, $24)
RETURNING id, received_at RETURNING id, received_at
`, destMailboxID, destFolderID, destUID, blobID, senderAddress, recipientAddresses, sizeBytes, spfResult, dkimResult, dmarcResult, `, destMailboxID, destFolderID, destUID, destModSeq, blobID, senderAddress, recipientAddresses, sizeBytes, spfResult, dkimResult, dmarcResult,
fromDisplayName, subject, snippet, messageIDHeader, inReplyTo, threadID, hasAttachments, fromDisplayName, subject, snippet, messageIDHeader, inReplyTo, threadID, hasAttachments,
arcResult, daneStatus, tlsVersion, spamScore, spamVerdict, virusName).Scan(&destMessageID, &destReceivedAt) arcResult, daneStatus, tlsVersion, spamScore, spamVerdict, virusName).Scan(&destMessageID, &destReceivedAt)
if err != nil { if err != nil {
@@ -71,7 +71,7 @@ func (r *ExpungeRepository) Expunge(ctx context.Context, folderID string, uids [
unreadDelta = 1 unreadDelta = 1
} }
if _, err := tx.Exec(ctx, ` if _, err := tx.Exec(ctx, `
UPDATE folders SET total_count = total_count - 1, unread_count = unread_count - $1 UPDATE folders SET total_count = total_count - 1, unread_count = unread_count - $1, highest_modseq = highest_modseq + 1
WHERE id = $2 WHERE id = $2
`, unreadDelta, folderID); err != nil { `, unreadDelta, folderID); err != nil {
return fmt.Errorf("decrement folder counters for uid %d: %w", uid, err) return fmt.Errorf("decrement folder counters for uid %d: %w", uid, err)
@@ -18,55 +18,79 @@ func NewFlagRepository(pool *pgxpool.Pool) *FlagRepository {
return &FlagRepository{pool: pool} return &FlagRepository{pool: pool}
} }
func (r *FlagRepository) SetFlags(ctx context.Context, folderID string, uid uint32, op port.FlagOp, flags []string) error { func (r *FlagRepository) SetFlags(ctx context.Context, folderID string, uid uint32, op port.FlagOp, flags []string, unchangedSince uint64) (bool, error) {
tx, err := r.pool.Begin(ctx) tx, err := r.pool.Begin(ctx)
if err != nil { if err != nil {
return fmt.Errorf("begin transaction: %w", err) return false, fmt.Errorf("begin transaction: %w", err)
} }
defer tx.Rollback(ctx) defer tx.Rollback(ctx)
var messageID string var currentModSeq uint64
var receivedAt any
if err := tx.QueryRow(ctx, ` if err := tx.QueryRow(ctx, `
SELECT id, received_at FROM email_messages WHERE folder_id = $1 AND uid = $2 SELECT modseq FROM email_messages WHERE folder_id = $1 AND uid = $2 AND expunged_at IS NULL
`, folderID, uid).Scan(&messageID, &receivedAt); err != nil { `, folderID, uid).Scan(&currentModSeq); err != nil {
return fmt.Errorf("find message folder=%s uid=%d: %w", folderID, uid, err) return false, fmt.Errorf("find message folder=%s uid=%d: %w", folderID, uid, err)
}
if unchangedSince > 0 && currentModSeq > unchangedSince {
return false, nil
}
var newModSeq uint64
if err := tx.QueryRow(ctx, `
UPDATE folders SET highest_modseq = highest_modseq + 1 WHERE id = $1 RETURNING highest_modseq
`, folderID).Scan(&newModSeq); err != nil {
return false, fmt.Errorf("advance highest_modseq for folder %s: %w", folderID, err)
}
if _, err := tx.Exec(ctx, `
UPDATE email_messages SET modseq = $1 WHERE folder_id = $2 AND uid = $3 AND expunged_at IS NULL
`, newModSeq, folderID, uid); err != nil {
return false, fmt.Errorf("update message modseq: %w", err)
} }
switch op { switch op {
case port.FlagOpAdd: case port.FlagOpAdd:
for _, flag := range flags { for _, flag := range flags {
if _, err := tx.Exec(ctx, ` if _, err := tx.Exec(ctx, `
INSERT INTO message_flags (message_id, received_at, flag) VALUES ($1, $2, $3) INSERT INTO message_flags (message_id, received_at, flag)
SELECT id, received_at, $3 FROM email_messages WHERE folder_id = $1 AND uid = $2 AND expunged_at IS NULL
ON CONFLICT DO NOTHING ON CONFLICT DO NOTHING
`, messageID, receivedAt, flag); err != nil { `, folderID, uid, flag); err != nil {
return fmt.Errorf("add flag %q: %w", flag, err) return false, fmt.Errorf("add flag %q: %w", flag, err)
} }
} }
case port.FlagOpDel: case port.FlagOpDel:
for _, flag := range flags { for _, flag := range flags {
if _, err := tx.Exec(ctx, ` if _, err := tx.Exec(ctx, `
DELETE FROM message_flags WHERE message_id = $1 AND received_at = $2 AND flag = $3 DELETE FROM message_flags WHERE (message_id, received_at) IN (
`, messageID, receivedAt, flag); err != nil { SELECT id, received_at FROM email_messages WHERE folder_id = $1 AND uid = $2 AND expunged_at IS NULL
return fmt.Errorf("delete flag %q: %w", flag, err) ) AND flag = $3
`, folderID, uid, flag); err != nil {
return false, fmt.Errorf("delete flag %q: %w", flag, err)
} }
} }
case port.FlagOpSet: case port.FlagOpSet:
if _, err := tx.Exec(ctx, `DELETE FROM message_flags WHERE message_id = $1 AND received_at = $2`, messageID, receivedAt); err != nil { if _, err := tx.Exec(ctx, `
return fmt.Errorf("clear flags before set: %w", err) DELETE FROM message_flags WHERE (message_id, received_at) IN (
SELECT id, received_at FROM email_messages WHERE folder_id = $1 AND uid = $2 AND expunged_at IS NULL
)
`, folderID, uid); err != nil {
return false, fmt.Errorf("clear flags before set: %w", err)
} }
for _, flag := range flags { for _, flag := range flags {
if _, err := tx.Exec(ctx, ` if _, err := tx.Exec(ctx, `
INSERT INTO message_flags (message_id, received_at, flag) VALUES ($1, $2, $3) INSERT INTO message_flags (message_id, received_at, flag)
SELECT id, received_at, $3 FROM email_messages WHERE folder_id = $1 AND uid = $2 AND expunged_at IS NULL
ON CONFLICT DO NOTHING ON CONFLICT DO NOTHING
`, messageID, receivedAt, flag); err != nil { `, folderID, uid, flag); err != nil {
return fmt.Errorf("set flag %q: %w", flag, err) return false, fmt.Errorf("set flag %q: %w", flag, err)
} }
} }
} }
if err := tx.Commit(ctx); err != nil { if err := tx.Commit(ctx); err != nil {
return fmt.Errorf("commit: %w", err) return false, fmt.Errorf("commit: %w", err)
} }
return nil return true, nil
} }
@@ -70,8 +70,8 @@ func TestFlagRepository_SetFlags_AddThenDelThenSet(t *testing.T) {
repo := NewFlagRepository(pool) repo := NewFlagRepository(pool)
if err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpAdd, []string{"\\Seen", "\\Flagged"}); err != nil { if updated, err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpAdd, []string{"\\Seen", "\\Flagged"}, 0); err != nil || !updated {
t.Fatalf("add: %v", err) t.Fatalf("add: updated=%v, err=%v", updated, err)
} }
got := readFlags() got := readFlags()
sort.Strings(got) sort.Strings(got)
@@ -79,16 +79,16 @@ func TestFlagRepository_SetFlags_AddThenDelThenSet(t *testing.T) {
t.Fatalf("after add: flags = %v, want [\\Flagged \\Seen]", got) t.Fatalf("after add: flags = %v, want [\\Flagged \\Seen]", got)
} }
if err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpDel, []string{"\\Flagged"}); err != nil { if updated, err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpDel, []string{"\\Flagged"}, 0); err != nil || !updated {
t.Fatalf("del: %v", err) t.Fatalf("del: updated=%v, err=%v", updated, err)
} }
got = readFlags() got = readFlags()
if len(got) != 1 || got[0] != "\\Seen" { if len(got) != 1 || got[0] != "\\Seen" {
t.Fatalf("after del: flags = %v, want [\\Seen]", got) t.Fatalf("after del: flags = %v, want [\\Seen]", got)
} }
if err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpSet, []string{"\\Answered"}); err != nil { if updated, err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpSet, []string{"\\Answered"}, 0); err != nil || !updated {
t.Fatalf("set: %v", err) t.Fatalf("set: updated=%v, err=%v", updated, err)
} }
got = readFlags() got = readFlags()
if len(got) != 1 || got[0] != "\\Answered" { if len(got) != 1 || got[0] != "\\Answered" {
@@ -99,11 +99,22 @@ func TestFlagRepository_SetFlags_AddThenDelThenSet(t *testing.T) {
// single command - must not fail the whole STORE with a primary key // single command - must not fail the whole STORE with a primary key
// violation on the second INSERT for the same (message_id, received_at, // violation on the second INSERT for the same (message_id, received_at,
// flag). // flag).
if err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpSet, []string{"\\Seen", "\\Seen"}); err != nil { if updated, err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpSet, []string{"\\Seen", "\\Seen"}, 0); err != nil || !updated {
t.Fatalf("set with duplicate flags in input: %v", err) t.Fatalf("set with duplicate flags in input: updated=%v, err=%v", updated, err)
} }
got = readFlags() got = readFlags()
if len(got) != 1 || got[0] != "\\Seen" { if len(got) != 1 || got[0] != "\\Seen" {
t.Fatalf("after set with duplicate input flags: flags = %v, want [\\Seen]", got) t.Fatalf("after set with duplicate input flags: flags = %v, want [\\Seen]", got)
} }
// Test UNCHANGEDSINCE conditional store:
// Message's modseq was updated during the previous SetFlags call.
// Providing a lower unchangedSince value must fail (return updated=false).
if updated, err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpSet, []string{"\\Flagged"}, 1); err != nil || updated {
t.Fatalf("conditional set with lower modseq: expected updated=false, got updated=%v, err=%v", updated, err)
}
// Providing a matching or higher unchangedSince value must succeed (return updated=true).
if updated, err := repo.SetFlags(ctx, folderID.String(), 7, port.FlagOpSet, []string{"\\Flagged"}, 100); err != nil || !updated {
t.Fatalf("conditional set with higher modseq: expected updated=true, got updated=%v, err=%v", updated, err)
}
} }
@@ -20,13 +20,13 @@ func NewImapFolderRepository(pool *pgxpool.Pool) *ImapFolderRepository {
func (r *ImapFolderRepository) FindByName(ctx context.Context, mailboxID, name string) (*port.ImapFolderRecord, error) { func (r *ImapFolderRepository) FindByName(ctx context.Context, mailboxID, name string) (*port.ImapFolderRecord, error) {
row := r.pool.QueryRow(ctx, ` row := r.pool.QueryRow(ctx, `
SELECT f.id, f.name, f.uid_next, f.uid_validity, f.total_count SELECT f.id, f.name, f.uid_next, f.uid_validity, f.total_count, f.highest_modseq
FROM folders f FROM folders f
WHERE f.mailbox_id = $1 AND f.name = $2 WHERE f.mailbox_id = $1 AND f.name = $2
`, mailboxID, name) `, mailboxID, name)
var rec port.ImapFolderRecord var rec port.ImapFolderRecord
if err := row.Scan(&rec.ID, &rec.Name, &rec.UIDNext, &rec.UIDValidity, &rec.NumMessages); err != nil { if err := row.Scan(&rec.ID, &rec.Name, &rec.UIDNext, &rec.UIDValidity, &rec.NumMessages, &rec.HighestModSeq); err != nil {
if err == pgx.ErrNoRows { if err == pgx.ErrNoRows {
return nil, nil return nil, nil
} }
@@ -37,7 +37,7 @@ func (r *ImapFolderRepository) FindByName(ctx context.Context, mailboxID, name s
func (r *ImapFolderRepository) ListFolders(ctx context.Context, mailboxID string) ([]port.ImapFolderRecord, error) { func (r *ImapFolderRepository) ListFolders(ctx context.Context, mailboxID string) ([]port.ImapFolderRecord, error) {
rows, err := r.pool.Query(ctx, ` rows, err := r.pool.Query(ctx, `
SELECT f.id, f.name, f.uid_next, f.uid_validity, f.total_count SELECT f.id, f.name, f.uid_next, f.uid_validity, f.total_count, f.highest_modseq
FROM folders f FROM folders f
WHERE f.mailbox_id = $1 WHERE f.mailbox_id = $1
ORDER BY f.name ORDER BY f.name
@@ -50,7 +50,7 @@ func (r *ImapFolderRepository) ListFolders(ctx context.Context, mailboxID string
var out []port.ImapFolderRecord var out []port.ImapFolderRecord
for rows.Next() { for rows.Next() {
var rec port.ImapFolderRecord var rec port.ImapFolderRecord
if err := rows.Scan(&rec.ID, &rec.Name, &rec.UIDNext, &rec.UIDValidity, &rec.NumMessages); err != nil { if err := rows.Scan(&rec.ID, &rec.Name, &rec.UIDNext, &rec.UIDValidity, &rec.NumMessages, &rec.HighestModSeq); err != nil {
return nil, err return nil, err
} }
out = append(out, rec) out = append(out, rec)
@@ -39,21 +39,23 @@ func (r *InboundMessageRepository) Persist(ctx context.Context, input port.Persi
return 0, fmt.Errorf("find inbox folder for mailbox %s: %w", input.MailboxID, err) return 0, fmt.Errorf("find inbox folder for mailbox %s: %w", input.MailboxID, err)
} }
if _, err := tx.Exec(ctx, ` var modseq int64
UPDATE folders SET uid_next = uid_next + 1, unread_count = unread_count + 1, total_count = total_count + 1 if err := tx.QueryRow(ctx, `
UPDATE folders SET uid_next = uid_next + 1, highest_modseq = highest_modseq + 1, unread_count = unread_count + 1, total_count = total_count + 1
WHERE id = $1 WHERE id = $1
`, folderID); err != nil { RETURNING highest_modseq
return 0, fmt.Errorf("advance uid_next and folder counters: %w", err) `, folderID).Scan(&modseq); err != nil {
return 0, fmt.Errorf("advance uid_next, highest_modseq and folder counters: %w", err)
} }
// email_messages.id defaults to gen_random_uuid() per the migration - no explicit value needed. // email_messages.id defaults to gen_random_uuid() per the migration - no explicit value needed.
_, err = tx.Exec(ctx, ` _, err = tx.Exec(ctx, `
INSERT INTO email_messages ( INSERT INTO email_messages (
mailbox_id, folder_id, uid, blob_id, mailbox_id, folder_id, uid, modseq, blob_id,
sender_address, recipient_addresses, size_bytes, sender_address, recipient_addresses, size_bytes,
spf_result, dkim_result, dmarc_result spf_result, dkim_result, dmarc_result
) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10) ) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11)
`, input.MailboxID, folderID, uid, input.Blob.ID, `, input.MailboxID, folderID, uid, modseq, input.Blob.ID,
input.SenderAddress, []string{input.RecipientAddress}, input.Blob.SizeBytes, input.SenderAddress, []string{input.RecipientAddress}, input.Blob.SizeBytes,
input.SPFResult, input.DKIMResult, input.DMARCResult) input.SPFResult, input.DKIMResult, input.DMARCResult)
if err != nil { if err != nil {
@@ -19,12 +19,12 @@ func NewMessageQueryRepository(pool *pgxpool.Pool) *MessageQueryRepository {
func (r *MessageQueryRepository) ListMessages(ctx context.Context, folderID string) ([]port.MessageRecord, error) { func (r *MessageQueryRepository) ListMessages(ctx context.Context, folderID string) ([]port.MessageRecord, error) {
rows, err := r.pool.Query(ctx, ` rows, err := r.pool.Query(ctx, `
SELECT m.uid, m.blob_id, m.size_bytes, m.received_at, SELECT m.uid, m.blob_id, m.size_bytes, m.received_at, m.modseq,
COALESCE(array_agg(f.flag) FILTER (WHERE f.flag IS NOT NULL), '{}') COALESCE(array_agg(f.flag) FILTER (WHERE f.flag IS NOT NULL), '{}')
FROM email_messages m FROM email_messages m
LEFT JOIN message_flags f ON f.message_id = m.id AND f.received_at = m.received_at LEFT JOIN message_flags f ON f.message_id = m.id AND f.received_at = m.received_at
WHERE m.folder_id = $1 AND m.expunged_at IS NULL WHERE m.folder_id = $1 AND m.expunged_at IS NULL
GROUP BY m.uid, m.blob_id, m.size_bytes, m.received_at GROUP BY m.uid, m.blob_id, m.size_bytes, m.received_at, m.modseq
ORDER BY m.uid ASC ORDER BY m.uid ASC
`, folderID) `, folderID)
if err != nil { if err != nil {
@@ -35,7 +35,7 @@ func (r *MessageQueryRepository) ListMessages(ctx context.Context, folderID stri
var out []port.MessageRecord var out []port.MessageRecord
for rows.Next() { for rows.Next() {
var rec port.MessageRecord var rec port.MessageRecord
if err := rows.Scan(&rec.UID, &rec.BlobID, &rec.SizeBytes, &rec.ReceivedAt, &rec.Flags); err != nil { if err := rows.Scan(&rec.UID, &rec.BlobID, &rec.SizeBytes, &rec.ReceivedAt, &rec.ModSeq, &rec.Flags); err != nil {
return nil, err return nil, err
} }
out = append(out, rec) out = append(out, rec)
@@ -19,6 +19,7 @@ type session struct {
useCase *usecase.ImapSessionUseCase useCase *usecase.ImapSessionUseCase
mailboxID string mailboxID string
selectedFolder *port.ImapFolderRecord selectedFolder *port.ImapFolderRecord
tracker *imapserver.SessionTracker
} }
// NewSession is the imapserver.Options.NewSession callback. // NewSession is the imapserver.Options.NewSession callback.
@@ -37,7 +38,13 @@ func toIMAPError(err error) error {
} }
} }
func (s *session) Close() error { return nil } func (s *session) Close() error {
if s.tracker != nil {
s.tracker.Close()
s.tracker = nil
}
return nil
}
func (s *session) Login(username, password string) error { func (s *session) Login(username, password string) error {
mailboxID, err := s.useCase.Login(context.Background(), username, password) mailboxID, err := s.useCase.Login(context.Background(), username, password)
@@ -53,15 +60,27 @@ func (s *session) Select(mailbox string, _ *imap.SelectOptions) (*imap.SelectDat
if err != nil { if err != nil {
return nil, toIMAPError(err) return nil, toIMAPError(err)
} }
if s.tracker != nil {
s.tracker.Close()
s.tracker = nil
}
s.selectedFolder = rec s.selectedFolder = rec
if tm := s.useCase.GetTrackerManager(); tm != nil {
s.tracker = tm.GetTracker(rec.ID, rec.NumMessages).NewSession()
}
return &imap.SelectData{ return &imap.SelectData{
NumMessages: rec.NumMessages, NumMessages: rec.NumMessages,
UIDNext: imap.UID(rec.UIDNext), UIDNext: imap.UID(rec.UIDNext),
UIDValidity: rec.UIDValidity, UIDValidity: rec.UIDValidity,
HighestModSeq: rec.HighestModSeq,
}, nil }, nil
} }
func (s *session) Unselect() error { func (s *session) Unselect() error {
if s.tracker != nil {
s.tracker.Close()
s.tracker = nil
}
s.selectedFolder = nil s.selectedFolder = nil
return nil return nil
} }
@@ -82,9 +101,26 @@ func (s *session) Status(mailbox string, options *imap.StatusOptions) (*imap.Sta
if options.UIDValidity { if options.UIDValidity {
data.UIDValidity = rec.UIDValidity data.UIDValidity = rec.UIDValidity
} }
if options.HighestModSeq {
data.HighestModSeq = rec.HighestModSeq
}
return data, nil return data, nil
} }
func (s *session) Poll(w *imapserver.UpdateWriter, allowExpunge bool) error {
if s.tracker == nil {
return nil
}
return s.tracker.Poll(w, allowExpunge)
}
func (s *session) Idle(w *imapserver.UpdateWriter, stop <-chan struct{}) error {
if s.tracker == nil {
return nil
}
return s.tracker.Idle(w, stop)
}
func (s *session) List(w *imapserver.ListWriter, ref string, patterns []string, options *imap.ListOptions) error { func (s *session) List(w *imapserver.ListWriter, ref string, patterns []string, options *imap.ListOptions) error {
recs, err := s.useCase.ListFolders(context.Background(), s.mailboxID) recs, err := s.useCase.ListFolders(context.Background(), s.mailboxID)
if err != nil { if err != nil {
@@ -153,6 +189,9 @@ func (s *session) Fetch(w *imapserver.FetchWriter, numSet imap.NumSet, options *
if fetchErr != nil { if fetchErr != nil {
return return
} }
if options.ChangedSince > 0 && msg.ModSeq <= options.ChangedSince {
return
}
respWriter := w.CreateMessage(seqNum) respWriter := w.CreateMessage(seqNum)
fetchErr = s.writeFetchResponse(respWriter, msg, options) fetchErr = s.writeFetchResponse(respWriter, msg, options)
}) })
@@ -273,6 +312,11 @@ func (s *session) Expunge(w *imapserver.ExpungeWriter, uids *imap.UIDSet) error
if err != nil { if err != nil {
return err return err
} }
if tm := s.useCase.GetTrackerManager(); tm != nil && s.selectedFolder != nil {
for _, seqNum := range seqNums {
tm.NotifyExpunge(s.selectedFolder.ID, seqNum)
}
}
// w is nil in unit tests that only assert the use-case call, since // w is nil in unit tests that only assert the use-case call, since
// *imapserver.ExpungeWriter has no exported constructor and can only be // *imapserver.ExpungeWriter has no exported constructor and can only be
// built by a live *imapserver.Conn (same constraint as *ListWriter - // built by a live *imapserver.Conn (same constraint as *ListWriter -
@@ -317,6 +361,9 @@ func (s *session) Copy(numSet imap.NumSet, dest string) (*imap.CopyData, error)
sourceUIDs.AddNum(imap.UID(c.SourceUID)) sourceUIDs.AddNum(imap.UID(c.SourceUID))
destUIDs.AddNum(imap.UID(c.DestUID)) destUIDs.AddNum(imap.UID(c.DestUID))
} }
if tm := s.useCase.GetTrackerManager(); tm != nil {
tm.NotifyNumMessages(destFolder.ID, destFolder.NumMessages+uint32(len(copied)))
}
return &imap.CopyData{UIDValidity: destFolder.UIDValidity, SourceUIDs: sourceUIDs, DestUIDs: destUIDs}, nil return &imap.CopyData{UIDValidity: destFolder.UIDValidity, SourceUIDs: sourceUIDs, DestUIDs: destUIDs}, nil
} }
@@ -345,6 +392,11 @@ func (s *session) Move(w *imapserver.MoveWriter, numSet imap.NumSet, dest string
if err != nil { if err != nil {
return err return err
} }
if tm := s.useCase.GetTrackerManager(); tm != nil && s.selectedFolder != nil {
for _, seqNum := range seqNums {
tm.NotifyExpunge(s.selectedFolder.ID, seqNum)
}
}
// w is nil in unit tests that only assert the use-case call, mirroring // w is nil in unit tests that only assert the use-case call, mirroring
// Expunge's nil-writer accommodation above. // Expunge's nil-writer accommodation above.
if w == nil { if w == nil {
@@ -376,23 +428,30 @@ func (s *session) Store(w *imapserver.FetchWriter, numSet imap.NumSet, flags *im
flagNames[i] = string(f) flagNames[i] = string(f)
} }
var unchangedSince uint64
if options != nil {
unchangedSince = options.UnchangedSince
}
messages, err := s.useCase.FetchMessages(context.Background(), s.selectedFolder.ID) messages, err := s.useCase.FetchMessages(context.Background(), s.selectedFolder.ID)
if err != nil { if err != nil {
return toIMAPError(err) return toIMAPError(err)
} }
// Resolve numSet against the folder's real message list (same pattern as
// Fetch), rather than pulling raw values via NumSet.Nums(): dynamic
// ranges like "1:*" cannot be resolved without a concrete candidate to
// test against, and Nums() returns (nil, false) for them. This also
// naturally supports plain (non-UID) STORE via the SeqSet case.
var storeErr error var storeErr error
s.numSetIter(numSet, messages, func(_ uint32, msg port.MessageRecord) { s.numSetIter(numSet, messages, func(seqNum uint32, msg port.MessageRecord) {
if storeErr != nil { if storeErr != nil {
return return
} }
if err := s.useCase.SetFlags(context.Background(), s.selectedFolder.ID, msg.UID, op, flagNames); err != nil { updated, err := s.useCase.SetFlags(context.Background(), s.selectedFolder.ID, msg.UID, op, flagNames, unchangedSince)
if err != nil {
storeErr = toIMAPError(err) storeErr = toIMAPError(err)
return
}
if updated {
if tm := s.useCase.GetTrackerManager(); tm != nil {
tm.NotifyMessageFlags(s.selectedFolder.ID, seqNum, msg.UID, flagNames, s.tracker)
}
} }
}) })
if storeErr != nil { if storeErr != nil {
@@ -69,10 +69,10 @@ type fakeFlagCall struct {
flags []string flags []string
} }
func (f *fakeFlagRepository) SetFlags(_ context.Context, folderID string, uid uint32, op port.FlagOp, flags []string) error { func (f *fakeFlagRepository) SetFlags(_ context.Context, folderID string, uid uint32, op port.FlagOp, flags []string, _ uint64) (bool, error) {
f.lastFolderID, f.lastUID, f.lastOp, f.lastFlags = folderID, uid, op, flags f.lastFolderID, f.lastUID, f.lastOp, f.lastFlags = folderID, uid, op, flags
f.calls = append(f.calls, fakeFlagCall{folderID: folderID, uid: uid, op: op, flags: flags}) f.calls = append(f.calls, fakeFlagCall{folderID: folderID, uid: uid, op: op, flags: flags})
return nil return true, nil
} }
type fakeBlobReader struct { type fakeBlobReader struct {
@@ -451,7 +451,7 @@ func TestSession_Expunge_CallsUseCaseWithDeletedUIDsOnly(t *testing.T) {
auth := &fakeAuthRepository{byAddress: map[string]port.MailboxAuth{ auth := &fakeAuthRepository{byAddress: map[string]port.MailboxAuth{
"user@example.test": {ID: mailboxID, PasswordHash: testPasswordHash}, "user@example.test": {ID: mailboxID, PasswordHash: testPasswordHash},
}} }}
folders := &fakeImapFolderRepository{byName: map[string]port.ImapFolderRecord{"INBOX": {ID: "folder-1"}}} folders := &fakeImapFolderRepository{byName: map[string]port.ImapFolderRecord{"INBOX": {ID: "folder-1", NumMessages: 3}}}
messages := &fakeMessageQueryRepository{messages: []port.MessageRecord{ messages := &fakeMessageQueryRepository{messages: []port.MessageRecord{
{UID: 1, Flags: []string{"\\Deleted"}}, {UID: 1, Flags: []string{"\\Deleted"}},
{UID: 2, Flags: nil}, {UID: 2, Flags: nil},
@@ -534,7 +534,7 @@ func TestSession_Move_ExpungesCopiedMessageEvenWithoutDeletedFlag(t *testing.T)
"user@example.test": {ID: mailboxID, PasswordHash: testPasswordHash}, "user@example.test": {ID: mailboxID, PasswordHash: testPasswordHash},
}} }}
folders := &fakeImapFolderRepository{byName: map[string]port.ImapFolderRecord{ folders := &fakeImapFolderRepository{byName: map[string]port.ImapFolderRecord{
"INBOX": {ID: "folder-1"}, "INBOX": {ID: "folder-1", NumMessages: 1},
"Archive": {ID: "folder-2", UIDValidity: 42}, "Archive": {ID: "folder-2", UIDValidity: 42},
}} }}
// UID 5 has no \Deleted flag - MOVE must still expunge it from the // UID 5 has no \Deleted flag - MOVE must still expunge it from the
@@ -46,7 +46,7 @@ func (s *session) Search(numKind imapserver.NumKind, criteria *imap.SearchCriter
return s.useCase.ReadBlob(context.Background(), blobID) return s.useCase.ReadBlob(context.Background(), blobID)
} }
if !matchCriteria(seqNum, msg.UID, msg.ReceivedAt, msg.SizeBytes, flags, criteria, loadRaw) { if !matchCriteria(seqNum, msg.UID, msg.ReceivedAt, msg.SizeBytes, msg.ModSeq, flags, criteria, loadRaw) {
continue continue
} }
@@ -81,7 +81,7 @@ func (s *session) Search(numKind imapserver.NumKind, criteria *imap.SearchCriter
// actually needs them (Header/Body/Text/SentSince/SentBefore), since this // actually needs them (Header/Body/Text/SentSince/SentBefore), since this
// codebase is Postgres-backed with blobs fetched on demand rather than // codebase is Postgres-backed with blobs fetched on demand rather than
// always held in memory like imapmemserver's reference message buffer. // always held in memory like imapmemserver's reference message buffer.
func matchCriteria(seqNum, uid uint32, receivedAt time.Time, sizeBytes int64, flags []imap.Flag, criteria *imap.SearchCriteria, loadRaw func() ([]byte, error)) bool { func matchCriteria(seqNum, uid uint32, receivedAt time.Time, sizeBytes int64, modSeq uint64, flags []imap.Flag, criteria *imap.SearchCriteria, loadRaw func() ([]byte, error)) bool {
for _, seqSet := range criteria.SeqNum { for _, seqSet := range criteria.SeqNum {
if seqNum == 0 || !seqSet.Contains(seqNum) { if seqNum == 0 || !seqSet.Contains(seqNum) {
return false return false
@@ -96,6 +96,12 @@ func matchCriteria(seqNum, uid uint32, receivedAt time.Time, sizeBytes int64, fl
return false return false
} }
if criteria.ModSeq != nil && criteria.ModSeq.ModSeq > 0 {
if modSeq < criteria.ModSeq.ModSeq {
return false
}
}
flagSet := make(map[imap.Flag]struct{}, len(flags)) flagSet := make(map[imap.Flag]struct{}, len(flags))
for _, f := range flags { for _, f := range flags {
flagSet[canonicalFlag(f)] = struct{}{} flagSet[canonicalFlag(f)] = struct{}{}
@@ -159,13 +165,13 @@ func matchCriteria(seqNum, uid uint32, receivedAt time.Time, sizeBytes int64, fl
} }
for _, not := range criteria.Not { for _, not := range criteria.Not {
if matchCriteria(seqNum, uid, receivedAt, sizeBytes, flags, &not, loadRaw) { if matchCriteria(seqNum, uid, receivedAt, sizeBytes, modSeq, flags, &not, loadRaw) {
return false return false
} }
} }
for _, or := range criteria.Or { for _, or := range criteria.Or {
if !matchCriteria(seqNum, uid, receivedAt, sizeBytes, flags, &or[0], loadRaw) && if !matchCriteria(seqNum, uid, receivedAt, sizeBytes, modSeq, flags, &or[0], loadRaw) &&
!matchCriteria(seqNum, uid, receivedAt, sizeBytes, flags, &or[1], loadRaw) { !matchCriteria(seqNum, uid, receivedAt, sizeBytes, modSeq, flags, &or[1], loadRaw) {
return false return false
} }
} }
@@ -9,7 +9,6 @@ package imappresentation
import ( import (
"github.com/emersion/go-imap/v2" "github.com/emersion/go-imap/v2"
"github.com/emersion/go-imap/v2/imapserver"
) )
var errNotYetImplemented = &imap.Error{ var errNotYetImplemented = &imap.Error{
@@ -25,14 +24,4 @@ func (s *session) Unsubscribe(_ string) error { return errN
func (s *session) Append(_ string, _ imap.LiteralReader, _ *imap.AppendOptions) (*imap.AppendData, error) { func (s *session) Append(_ string, _ imap.LiteralReader, _ *imap.AppendOptions) (*imap.AppendData, error) {
return nil, errNotYetImplemented return nil, errNotYetImplemented
} }
// Poll is called by imapserver before the status response of nearly every
// command in the Authenticated/Selected state (see conn.go's c.poll), not
// just in response to an explicit client IDLE/NOOP - returning an error here
// would fail every real command (FETCH, STORE, ...), not just polling. This
// sub-project doesn't push unsolicited EXISTS/EXPUNGE/FETCH updates (no
// IDLE support - see Idle below), so reporting "no updates" via a nil
// return is the correct, spec-compliant no-op, not a stub.
func (s *session) Poll(_ *imapserver.UpdateWriter, _ bool) error { return nil }
func (s *session) Idle(_ *imapserver.UpdateWriter, _ <-chan struct{}) error {
return errNotYetImplemented
}