#4: implement F2 sub-project 1 - IMAP core (auth, LIST, SELECT, FETCH, STORE)

Adds a real :143 IMAP listener to the Go protocols service: a mailbox
owner authenticates over IMAP (Argon2id against mailboxes.password_hash,
enumeration-resistant per PLAN.md section 14.6), lists folders, selects
INBOX, fetches messages F1's SMTP path already persisted - including real
ENVELOPE/BODY[] built from the actual stored MIME bytes via go-imap/v2's
own ExtractEnvelope/ExtractBodySection helpers, not reconstructed from
denormalized columns - and sets/reads flags via STORE.

- ImapSessionUseCase orchestrates auth, folder listing/selection, message
  querying, and flag mutation against new Postgres repositories (auth,
  folders, message query, flags) and a local-disk blob reader.
- A github.com/emersion/go-imap/v2 (pinned v2.0.0-beta.8) Backend/Session
  implements 7 real methods (Login, List, Select, Unselect, Status, Fetch,
  Store) plus a correct no-op Poll; the other 10 of the interface's 18
  methods (Create/Delete/Rename/Subscribe/Unsubscribe/Append/Idle/Expunge/
  Search/Copy) are explicit stubs returning a clear "not yet implemented"
  IMAP error - SEARCH/EXPUNGE/COPY/MOVE, IDLE/CONDSTORE, mailbox
  management, and APPEND are separate follow-up sub-projects per the
  design doc's agreed ordering with the user.

Verified end-to-end with a real go-imap/v2 imapclient (embedded Postgres,
no Docker needed) driving Login -> Select -> Fetch -> Store -> List
against a message seeded through F1's real SMTP use case, proving true
SMTP-write/IMAP-read interop, not just isolated unit tests.

Built via 8 sequential tasks under subagent-driven development, each
independently reviewed, plus a final whole-branch review. Two real bugs
were found and fixed before merge, both exactly the kind unit tests with
fakes cannot catch:
- Store's UID-set resolution silently no-op'd on dynamic ranges like
  "UID STORE 1:*" (the common "mark all as read" operation) after an
  earlier draft bypassed the folder's real message list; restored to
  resolve against real messages via the same pattern Fetch already used
  correctly, with tests proving both dynamic ranges and non-UID STORE.
- go-imap/v2's server calls Session.Poll() implicitly before the status
  response of nearly every authenticated command (FETCH/STORE/SEARCH/
  APPEND/COPY), not just IDLE as assumed - a hard-stubbed Poll broke every
  real command through this path; fixed to a correct no-op.
- List had zero test coverage despite being committed scope; added unit
  tests for wildcard/delimiter matching plus a real E2E LIST assertion.

Known follow-up, not blocking: a pre-existing test-fixture hygiene gap
(hardcoded content_sha256 blob hashes with no cleanup, shared across
several Postgres integration test files including one new to this
branch) causes local-dev test collisions on repeated runs against a
persistent database - invisible to CI (fresh Postgres per run) but worth
a cleanup pass.
This commit is contained in:
Lucas Rayan committed 2026-07-23 20:34:48 -03:00
1 parent fc8bbaa3ce
commit 9fa19291d4
25 files changed
+1920 -1

No files matched your search

@@ -0,0 +1,32 @@
package diskstorage
import (
"context"
"fmt"
"os"
"github.com/google/uuid"
"github.com/jackc/pgx/v5/pgxpool"
)
// LocalDiskBlobReader implements port.BlobReader by looking up the blob's
// storage_path in Postgres, then reading the full file from local disk.
type LocalDiskBlobReader struct {
pool *pgxpool.Pool
}
func NewLocalDiskBlobReader(pool *pgxpool.Pool) *LocalDiskBlobReader {
return &LocalDiskBlobReader{pool: pool}
}
func (r *LocalDiskBlobReader) ReadByID(ctx context.Context, blobID uuid.UUID) ([]byte, error) {
var path string
if err := r.pool.QueryRow(ctx, `SELECT storage_path FROM message_blobs WHERE id = $1`, blobID).Scan(&path); err != nil {
return nil, fmt.Errorf("find blob %s: %w", blobID, err)
}
data, err := os.ReadFile(path)
if err != nil {
return nil, fmt.Errorf("read blob file %s: %w", path, err)
}
return data, nil
}
@@ -0,0 +1,43 @@
package diskstorage
import (
"bytes"
"context"
"testing"
"github.com/google/uuid"
)
func TestLocalDiskBlobReader_ReadByID_ReturnsStoredContent(t *testing.T) {
pool := testPoolForBlobStorage(t)
defer pool.Close()
dir := t.TempDir()
storage := NewLocalDiskBlobStorage(pool, dir)
reader := NewLocalDiskBlobReader(pool)
content := []byte("Subject: read test\r\n\r\nhello reader")
ref, err := storage.Store(context.Background(), bytes.NewReader(content))
if err != nil {
t.Fatalf("Store: %v", err)
}
defer pool.Exec(context.Background(), `DELETE FROM message_blobs WHERE id = $1`, ref.ID)
got, err := reader.ReadByID(context.Background(), ref.ID)
if err != nil {
t.Fatalf("ReadByID: %v", err)
}
if !bytes.Equal(got, content) {
t.Errorf("ReadByID content = %q, want %q", got, content)
}
}
func TestLocalDiskBlobReader_ReadByID_ReturnsErrorForUnknownID(t *testing.T) {
pool := testPoolForBlobStorage(t)
defer pool.Close()
reader := NewLocalDiskBlobReader(pool)
_, err := reader.ReadByID(context.Background(), uuid.New())
if err == nil {
t.Fatal("expected an error for an unknown (random) blob ID, got nil")
}
}