#25: deliver mail addressed to this server without going out to the internet
Every message was resolved through MX and delivered over SMTP, including one addressed to a mailbox on this very host. Two users on the same server could not write to each other without a working outbound port 25 - which the provider blocks, so on this deployment they could not write to each other at all. It also made internal mail take a pointless round trip through the public internet. The worker now checks whether the recipient resolves to a local mailbox and, if so, hands the message to the inbound path directly. The check runs ahead of the relay branch on purpose: sending local mail out to a smarthost only to have it delivered back is slower and has more ways to fail. The shortcut is narrow. It relies on ResolveDeliveryTargets, which only resolves addresses on an active local domain, and a test covers that a remote recipient still goes out over SMTP - otherwise local delivery would swallow mail meant for the internet. A resolver error is treated as retry rather than as not-local: falling through to SMTP on an unknown answer would send to the internet a message that may belong here. Local delivery is still content-scanned; a virus between two accounts on one host is no less a virus. This also surfaced a permissive test double: fakeAliasFanOutRepository claimed every address was local, which was harmless while nothing consulted it while routing and wrong the moment something did. It now hosts one address, as the real repository does, and the DSN fan-out test names it explicitly. Verified: the local-delivery test fails without the change (the recipient triggers an MX lookup) and passes with it; 22 Go packages green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
0fcdd15b58
commit
c83f2f75b2
5 files changed
+198
-3
No files matched your search
@@ -83,15 +83,25 @@ func TestUseCase_ResolveRecipient_ReturnsErrMailboxQuotaExceededWhenAnyFanOutTar
|
||||
}
|
||||
|
||||
// fakeAliasFanOutRepository simulates an alias resolving to multiple mailboxes.
|
||||
//
|
||||
// localAddress is the one address it hosts. It used to answer for any address
|
||||
// at all, which made every recipient look local - harmless while nothing
|
||||
// consulted it on the delivery path, and wrong the moment local delivery
|
||||
// started asking. The real repository only ever resolves addresses on an
|
||||
// active local domain.
|
||||
type fakeAliasFanOutRepository struct {
|
||||
targets []port.MailboxRecord
|
||||
localAddress string
|
||||
targets []port.MailboxRecord
|
||||
}
|
||||
|
||||
func (f *fakeAliasFanOutRepository) FindActiveByAddress(_ context.Context, _ string) (*port.MailboxRecord, error) {
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
func (f *fakeAliasFanOutRepository) ResolveDeliveryTargets(_ context.Context, _ string) ([]port.MailboxRecord, error) {
|
||||
func (f *fakeAliasFanOutRepository) ResolveDeliveryTargets(_ context.Context, address string) ([]port.MailboxRecord, error) {
|
||||
if f.localAddress != "" && address != f.localAddress {
|
||||
return []port.MailboxRecord{}, nil
|
||||
}
|
||||
return f.targets, nil
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user