Add end-to-end tests for TLS RPT report ingestion and WebSocket event handling
- Implemented tests for ingesting TLS RPT reports from emails and ensuring they are stored correctly in the database. - Added tests to verify that the same report can be ingested multiple times without duplication. - Created tests for backfilling reports that were previously delivered to the inbox. - Developed WebSocket event handling tests to ensure events are correctly routed to subscribers based on mailbox ownership. - Included tests for the mail API to validate session handling, mailbox isolation, and error mapping. - Ensured that the API rejects unauthorized requests and handles malformed JSON gracefully.
This commit is contained in:
1 parent
880dced9e4
commit
f330c4324e
28 files changed
+2438
-6
No files matched your search
@@ -25,16 +25,35 @@ func (r *ReportRepository) SaveDmarcReport(ctx context.Context, report *entity.D
|
||||
}
|
||||
defer tx.Rollback(ctx)
|
||||
|
||||
// Idempotent on (org_name, report_id): the reporter's own identifier for
|
||||
// the report. Reports are now parsed out of inbound mail automatically, so
|
||||
// a redelivery - an SMTP retry, or a reporter simply sending again - is
|
||||
// routine, and storing the same report twice would double every number the
|
||||
// admin console shows.
|
||||
//
|
||||
// DO UPDATE rather than DO NOTHING so the existing row's id comes back and
|
||||
// the records below can be reconciled against it; DO NOTHING returns no
|
||||
// row at all when it conflicts.
|
||||
var reportID uuid.UUID
|
||||
err = tx.QueryRow(ctx, `
|
||||
INSERT INTO dmarc_reports (org_name, report_id, domain, date_range_begin, date_range_end)
|
||||
VALUES ($1, $2, $3, $4, $5)
|
||||
ON CONFLICT (org_name, report_id)
|
||||
DO UPDATE SET domain = EXCLUDED.domain
|
||||
RETURNING id
|
||||
`, report.OrgName, report.ReportID, report.Domain, report.DateRangeBegin, report.DateRangeEnd).Scan(&reportID)
|
||||
if err != nil {
|
||||
return fmt.Errorf("insert dmarc report header: %w", err)
|
||||
}
|
||||
|
||||
// The records are replaced, not appended: on a redelivery the report's
|
||||
// previous rows are still here, and adding another set would double every
|
||||
// count derived from them.
|
||||
if _, err := tx.Exec(ctx,
|
||||
`DELETE FROM dmarc_report_records WHERE report_id = $1`, reportID); err != nil {
|
||||
return fmt.Errorf("clear dmarc records: %w", err)
|
||||
}
|
||||
|
||||
for _, rec := range report.Records {
|
||||
_, err := tx.Exec(ctx, `
|
||||
INSERT INTO dmarc_report_records (report_id, source_ip, count, disposition, dkim_result, spf_result, header_from)
|
||||
@@ -55,16 +74,24 @@ func (r *ReportRepository) SaveTlsRptReport(ctx context.Context, report *entity.
|
||||
}
|
||||
defer tx.Rollback(ctx)
|
||||
|
||||
// Idempotent for the same reason as the DMARC writer above.
|
||||
var reportID uuid.UUID
|
||||
err = tx.QueryRow(ctx, `
|
||||
INSERT INTO tls_rpt_reports (organization_name, report_id, domain, date_range_begin, date_range_end)
|
||||
VALUES ($1, $2, $3, $4, $5)
|
||||
ON CONFLICT (organization_name, report_id)
|
||||
DO UPDATE SET domain = EXCLUDED.domain
|
||||
RETURNING id
|
||||
`, report.OrganizationName, report.ReportID, report.Domain, report.DateRangeBegin, report.DateRangeEnd).Scan(&reportID)
|
||||
if err != nil {
|
||||
return fmt.Errorf("insert tls-rpt report header: %w", err)
|
||||
}
|
||||
|
||||
if _, err := tx.Exec(ctx,
|
||||
`DELETE FROM tls_rpt_report_policies WHERE report_id = $1`, reportID); err != nil {
|
||||
return fmt.Errorf("clear tls-rpt policies: %w", err)
|
||||
}
|
||||
|
||||
for _, pol := range report.Policies {
|
||||
_, err := tx.Exec(ctx, `
|
||||
INSERT INTO tls_rpt_report_policies (report_id, policy_type, success_count, failure_count)
|
||||
|
||||
Reference in new issue
Block a user