O painel respondia "DNS reconciliation needs a provider token to be configured" enquanto o token estava configurado e a funcionar: a varredura de fundo estava a publicar registos com ele nesse preciso momento. SetDnsReconciler so atribuia quando r.dns ja existia, e o main.go chama-o antes de SetAdminDnsAPI. Escrevia num struct que ainda nao existia, sem erro nem aviso, e a API era depois construida sem reconciliador nenhum. Os testes anteriores nao apanharam isto porque construiam o adminDnsAPI directamente -- justamente a fiacao que estava partida. O teste novo passa pelos setters do Router nas duas ordens possiveis. - o reconciliador passa a ser guardado no Router, logo a ordem deixa de contar - so e ligado quando ha token, para a rota poder dizer que esta indisponivel em vez de falar com a Cloudflare com um token vazio e reportar uma recusa - a mensagem deixa de culpar o token, que nao era a causa Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
231 lines
8.0 KiB
Go
231 lines
8.0 KiB
Go
package httppresentation
|
|
|
|
import (
|
|
"context"
|
|
"log"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"lambdamail/protocols/internal/domain/entity"
|
|
)
|
|
|
|
// DnsRecordVerifier answers whether one expected record is actually published.
|
|
// Implemented by the same public-resolver verifier the reconciler uses, so the
|
|
// console and the background sync agree on what "verified" means.
|
|
type DnsRecordVerifier interface {
|
|
VerifyRecord(ctx context.Context, record entity.DnsRecord) (bool, string)
|
|
}
|
|
|
|
// DnsSpecSource builds the records a domain is expected to publish. It lives
|
|
// behind an interface because assembling the spec needs the DKIM public keys,
|
|
// which only the service holding the vault can read.
|
|
type DnsSpecSource interface {
|
|
ExpectedRecords(ctx context.Context, domain string) ([]entity.DnsRecord, error)
|
|
}
|
|
|
|
// ReconcileResult is what one reconciliation did.
|
|
//
|
|
// Conflicts are reported rather than resolved: a record of the right type and
|
|
// name already holding somebody else's value is not this server's to
|
|
// overwrite - it may be the zone's mail, or a service nobody remembered.
|
|
type ReconcileResult struct {
|
|
Domain string `json:"domain"`
|
|
Created int `json:"created"`
|
|
Updated int `json:"updated"`
|
|
Unchanged int `json:"unchanged"`
|
|
Conflicts []string `json:"conflicts"`
|
|
Errors []string `json:"errors"`
|
|
}
|
|
|
|
// DomainReconciler publishes a domain's expected records through the DNS
|
|
// provider, creating what is missing and correcting what disagrees.
|
|
//
|
|
// This is the half the console never had. Verification could say a record was
|
|
// missing; nothing exposed the ability to then create it, even though the
|
|
// service holding the provider token could do exactly that.
|
|
type DomainReconciler interface {
|
|
ReconcileDomain(ctx context.Context, domain string) (ReconcileResult, error)
|
|
}
|
|
|
|
type adminDnsAPI struct {
|
|
spec DnsSpecSource
|
|
verifier DnsRecordVerifier
|
|
sessions *WebSessionVerifier
|
|
// reconciler is optional: without it the route reports that the feature
|
|
// is not configured rather than answering as though it had run.
|
|
reconciler DomainReconciler
|
|
}
|
|
|
|
// handleReconcile publishes the records a domain is missing.
|
|
//
|
|
// The console's reconcile button used to reach an endpoint that wrote an audit
|
|
// row and answered "REQUESTED" - it never touched DNS, and the operator was
|
|
// left with a list of missing records and no way to act on it.
|
|
func (a *adminDnsAPI) handleReconcile(w http.ResponseWriter, r *http.Request) {
|
|
token := bearerOrCookie(r, "lm_admin_session")
|
|
if token == "" {
|
|
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "Admin session required")
|
|
return
|
|
}
|
|
if _, err := a.sessions.RequireSurface(token, "admin"); err != nil {
|
|
// Creating DNS records is an administrative action; a webmail session
|
|
// carries the wrong audience and stops here.
|
|
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "Admin session required")
|
|
return
|
|
}
|
|
|
|
domain := strings.TrimSpace(r.URL.Query().Get("domain"))
|
|
if domain == "" {
|
|
writeError(w, http.StatusBadRequest, "DOMAIN_REQUIRED", "A domain is required")
|
|
return
|
|
}
|
|
if a.reconciler == nil {
|
|
writeError(w, http.StatusServiceUnavailable, "RECONCILER_UNAVAILABLE",
|
|
"DNS reconciliation is not available: the service started without a DNS provider")
|
|
return
|
|
}
|
|
|
|
result, err := a.reconciler.ReconcileDomain(r.Context(), domain)
|
|
if err != nil {
|
|
// Logged rather than echoed: a provider error can name the account or
|
|
// the zone, and that is not the browser's business.
|
|
log.Printf("dns: could not reconcile %s: %v", domain, err)
|
|
writeError(w, http.StatusBadGateway, "RECONCILE_FAILED",
|
|
"The DNS provider refused the request. Check the API token and the zone.")
|
|
return
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, result)
|
|
}
|
|
|
|
// handleVerify checks every expected record against public resolvers and
|
|
// reports each one individually.
|
|
//
|
|
// This is the endpoint the admin console's reconcile button had no equivalent
|
|
// of. The auth service answered it by writing an audit row and re-reading the
|
|
// stored status, because it has no resolver - so the console could only ever
|
|
// repeat what the database already believed. Verification belongs here, with
|
|
// the resolver and the record spec.
|
|
func (a *adminDnsAPI) handleVerify(w http.ResponseWriter, r *http.Request) {
|
|
token := bearerOrCookie(r, "lm_admin_session")
|
|
if token == "" {
|
|
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "Admin session required")
|
|
return
|
|
}
|
|
if _, err := a.sessions.RequireSurface(token, "admin"); err != nil {
|
|
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "Admin session required")
|
|
return
|
|
}
|
|
|
|
domain := strings.TrimSpace(r.URL.Query().Get("domain"))
|
|
if domain == "" {
|
|
writeError(w, http.StatusBadRequest, "DOMAIN_REQUIRED", "A domain is required")
|
|
return
|
|
}
|
|
|
|
expected, err := a.spec.ExpectedRecords(r.Context(), domain)
|
|
if err != nil {
|
|
writeError(w, http.StatusInternalServerError, "SPEC_FAILED", "Could not assemble the expected records")
|
|
return
|
|
}
|
|
|
|
type result struct {
|
|
Type string `json:"type"`
|
|
Name string `json:"name"`
|
|
Expected string `json:"expected"`
|
|
Verified bool `json:"verified"`
|
|
Detail string `json:"detail"`
|
|
Proxied bool `json:"proxied"`
|
|
}
|
|
|
|
results := make([]result, 0, len(expected))
|
|
verified := 0
|
|
for _, record := range expected {
|
|
ok, detail := a.verifier.VerifyRecord(r.Context(), record)
|
|
if ok {
|
|
verified++
|
|
}
|
|
results = append(results, result{
|
|
Type: record.Type,
|
|
Name: record.Name,
|
|
Expected: record.Value,
|
|
Verified: ok,
|
|
Detail: detail,
|
|
// Reported so the console can explain why a proxied record is
|
|
// checked for presence only: behind a proxy the published answer
|
|
// is the provider's address, never the value we asked for.
|
|
Proxied: record.Proxied,
|
|
})
|
|
}
|
|
|
|
status := "VERIFIED"
|
|
switch {
|
|
case len(results) == 0:
|
|
status = "UNKNOWN"
|
|
case verified == 0:
|
|
status = "MISSING"
|
|
case verified < len(results):
|
|
status = "PARTIAL"
|
|
}
|
|
|
|
writeJSON(w, http.StatusOK, map[string]any{
|
|
"domain": domain,
|
|
"status": status,
|
|
"verified": verified,
|
|
"total": len(results),
|
|
"records": results,
|
|
})
|
|
}
|
|
|
|
// SetAdminDnsAPI wires per-record DNS verification. Without a session secret
|
|
// the route answers 503 rather than opening unauthenticated.
|
|
func (r *Router) SetAdminDnsAPI(spec DnsSpecSource, verifier DnsRecordVerifier, sessionSecret string) {
|
|
if spec == nil || verifier == nil || sessionSecret == "" {
|
|
return
|
|
}
|
|
r.dns = &adminDnsAPI{
|
|
spec: spec, verifier: verifier, sessions: NewWebSessionVerifier(sessionSecret),
|
|
// Carried over from the router so the two setters can be called in
|
|
// either order. They could not before, and main.go called them in the
|
|
// order that lost the reconciler.
|
|
reconciler: r.dnsReconciler,
|
|
}
|
|
}
|
|
|
|
// handleAdminDnsReconcile publishes the records a domain is missing.
|
|
func (r *Router) handleAdminDnsReconcile(w http.ResponseWriter, req *http.Request) {
|
|
if req.Method != http.MethodPost {
|
|
writeError(w, http.StatusMethodNotAllowed, "METHOD_NOT_ALLOWED", "POST required")
|
|
return
|
|
}
|
|
if r.dns == nil {
|
|
writeError(w, http.StatusServiceUnavailable, "DNS_API_DISABLED",
|
|
"DNS reconciliation needs JWT_SECRET and a configured domain")
|
|
return
|
|
}
|
|
r.dns.handleReconcile(w, req)
|
|
}
|
|
|
|
// SetDnsReconciler enables the reconcile route to actually publish records.
|
|
// Without it the route reports that reconciliation is not configured.
|
|
func (r *Router) SetDnsReconciler(reconciler DomainReconciler) {
|
|
// Kept on the router as well as on the API. Assigning only to r.dns meant
|
|
// that calling this before SetAdminDnsAPI silently did nothing: the field
|
|
// was written to a struct that did not exist yet, and the console then
|
|
// reported reconciliation as unconfigured while the provider token was
|
|
// present and the background sweep was publishing records with it.
|
|
r.dnsReconciler = reconciler
|
|
if r.dns != nil {
|
|
r.dns.reconciler = reconciler
|
|
}
|
|
}
|
|
|
|
func (r *Router) handleAdminDnsVerify(w http.ResponseWriter, req *http.Request) {
|
|
if r.dns == nil {
|
|
writeError(w, http.StatusServiceUnavailable, "DNS_API_DISABLED",
|
|
"DNS verification needs JWT_SECRET and a configured domain")
|
|
return
|
|
}
|
|
r.dns.handleVerify(w, req)
|
|
}
|