Files
LambdaMail/services/protocols/internal/application/usecase/imap_session_test.go
T
Lucas Rayan 9fa19291d4 #4: implement F2 sub-project 1 - IMAP core (auth, LIST, SELECT, FETCH, STORE)
Adds a real :143 IMAP listener to the Go protocols service: a mailbox
owner authenticates over IMAP (Argon2id against mailboxes.password_hash,
enumeration-resistant per PLAN.md section 14.6), lists folders, selects
INBOX, fetches messages F1's SMTP path already persisted - including real
ENVELOPE/BODY[] built from the actual stored MIME bytes via go-imap/v2's
own ExtractEnvelope/ExtractBodySection helpers, not reconstructed from
denormalized columns - and sets/reads flags via STORE.

- ImapSessionUseCase orchestrates auth, folder listing/selection, message
  querying, and flag mutation against new Postgres repositories (auth,
  folders, message query, flags) and a local-disk blob reader.
- A github.com/emersion/go-imap/v2 (pinned v2.0.0-beta.8) Backend/Session
  implements 7 real methods (Login, List, Select, Unselect, Status, Fetch,
  Store) plus a correct no-op Poll; the other 10 of the interface's 18
  methods (Create/Delete/Rename/Subscribe/Unsubscribe/Append/Idle/Expunge/
  Search/Copy) are explicit stubs returning a clear "not yet implemented"
  IMAP error - SEARCH/EXPUNGE/COPY/MOVE, IDLE/CONDSTORE, mailbox
  management, and APPEND are separate follow-up sub-projects per the
  design doc's agreed ordering with the user.

Verified end-to-end with a real go-imap/v2 imapclient (embedded Postgres,
no Docker needed) driving Login -> Select -> Fetch -> Store -> List
against a message seeded through F1's real SMTP use case, proving true
SMTP-write/IMAP-read interop, not just isolated unit tests.

Built via 8 sequential tasks under subagent-driven development, each
independently reviewed, plus a final whole-branch review. Two real bugs
were found and fixed before merge, both exactly the kind unit tests with
fakes cannot catch:
- Store's UID-set resolution silently no-op'd on dynamic ranges like
  "UID STORE 1:*" (the common "mark all as read" operation) after an
  earlier draft bypassed the folder's real message list; restored to
  resolve against real messages via the same pattern Fetch already used
  correctly, with tests proving both dynamic ranges and non-UID STORE.
- go-imap/v2's server calls Session.Poll() implicitly before the status
  response of nearly every authenticated command (FETCH/STORE/SEARCH/
  APPEND/COPY), not just IDLE as assumed - a hard-stubbed Poll broke every
  real command through this path; fixed to a correct no-op.
- List had zero test coverage despite being committed scope; added unit
  tests for wildcard/delimiter matching plus a real E2E LIST assertion.

Known follow-up, not blocking: a pre-existing test-fixture hygiene gap
(hardcoded content_sha256 blob hashes with no cleanup, shared across
several Postgres integration test files including one new to this
branch) causes local-dev test collisions on repeated runs against a
persistent database - invisible to CI (fresh Postgres per run) but worth
a cleanup pass.
2026-07-23 20:34:48 -03:00

112 lines
3.5 KiB
Go

package usecase
import (
"context"
"errors"
"testing"
"github.com/google/uuid"
"lambdamail/protocols/internal/application/port"
)
const (
testPassword = "correct horse battery staple"
testPasswordHash = "$argon2id$v=19$m=65536,t=1,p=12$I88aUc0rZHHX+Bt+jX+4Ag$3jKTtg1khJjFo9az4iPvFLc3eKY8WKSFy/1YMXlKvSU"
)
type fakeAuthRepository struct {
byAddress map[string]port.MailboxAuth
}
func (f *fakeAuthRepository) FindByAddress(_ context.Context, address string) (*port.MailboxAuth, error) {
rec, ok := f.byAddress[address]
if !ok {
return nil, nil
}
return &rec, nil
}
func TestImapSessionUseCase_Login_SucceedsForCorrectPassword(t *testing.T) {
mailboxID := uuid.New()
// PHC hash for password "correct horse battery staple", generated with argon2id.CreateHash.
auth := &fakeAuthRepository{byAddress: map[string]port.MailboxAuth{
"user@example.test": {ID: mailboxID, PasswordHash: testPasswordHash},
}}
uc := NewImapSessionUseCase(auth, nil, nil, nil, nil)
gotID, err := uc.Login(context.Background(), "user@example.test", testPassword)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if gotID != mailboxID.String() {
t.Errorf("mailboxID = %q, want %q", gotID, mailboxID.String())
}
}
func TestImapSessionUseCase_Login_FailsForWrongPassword(t *testing.T) {
auth := &fakeAuthRepository{byAddress: map[string]port.MailboxAuth{
"user@example.test": {ID: uuid.New(), PasswordHash: testPasswordHash},
}}
uc := NewImapSessionUseCase(auth, nil, nil, nil, nil)
_, err := uc.Login(context.Background(), "user@example.test", "wrong-password")
if !errors.Is(err, ErrAuthFailed) {
t.Fatalf("error = %v, want ErrAuthFailed", err)
}
}
func TestImapSessionUseCase_Login_FailsForUnknownAddress(t *testing.T) {
auth := &fakeAuthRepository{byAddress: map[string]port.MailboxAuth{}}
uc := NewImapSessionUseCase(auth, nil, nil, nil, nil)
_, err := uc.Login(context.Background(), "nobody@example.test", "anything")
if !errors.Is(err, ErrAuthFailed) {
t.Fatalf("error = %v, want ErrAuthFailed (never a distinct \"no such user\" error - PLAN.md section 14.6)", err)
}
}
type fakeImapFolderRepository struct {
byName map[string]port.ImapFolderRecord
}
func (f *fakeImapFolderRepository) ListFolders(_ context.Context, _ string) ([]port.ImapFolderRecord, error) {
var out []port.ImapFolderRecord
for _, rec := range f.byName {
out = append(out, rec)
}
return out, nil
}
func (f *fakeImapFolderRepository) FindByName(_ context.Context, _ string, name string) (*port.ImapFolderRecord, error) {
rec, ok := f.byName[name]
if !ok {
return nil, nil
}
return &rec, nil
}
func TestImapSessionUseCase_SelectFolder_ReturnsRecordForExistingFolder(t *testing.T) {
folders := &fakeImapFolderRepository{byName: map[string]port.ImapFolderRecord{
"INBOX": {ID: "folder-1", Name: "INBOX", UIDNext: 3, UIDValidity: 1000, NumMessages: 2},
}}
uc := NewImapSessionUseCase(nil, folders, nil, nil, nil)
rec, err := uc.SelectFolder(context.Background(), "mailbox-1", "INBOX")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if rec.ID != "folder-1" || rec.UIDNext != 3 {
t.Errorf("rec = %+v, want folder-1 with UIDNext 3", rec)
}
}
func TestImapSessionUseCase_SelectFolder_ReturnsErrNoSuchFolderWhenMissing(t *testing.T) {
folders := &fakeImapFolderRepository{byName: map[string]port.ImapFolderRecord{}}
uc := NewImapSessionUseCase(nil, folders, nil, nil, nil)
_, err := uc.SelectFolder(context.Background(), "mailbox-1", "Nonexistent")
if !errors.Is(err, ErrNoSuchFolder) {
t.Fatalf("error = %v, want ErrNoSuchFolder", err)
}
}