Lucas Rayan
9fa19291d4
Adds a real :143 IMAP listener to the Go protocols service: a mailbox owner authenticates over IMAP (Argon2id against mailboxes.password_hash, enumeration-resistant per PLAN.md section 14.6), lists folders, selects INBOX, fetches messages F1's SMTP path already persisted - including real ENVELOPE/BODY[] built from the actual stored MIME bytes via go-imap/v2's own ExtractEnvelope/ExtractBodySection helpers, not reconstructed from denormalized columns - and sets/reads flags via STORE. - ImapSessionUseCase orchestrates auth, folder listing/selection, message querying, and flag mutation against new Postgres repositories (auth, folders, message query, flags) and a local-disk blob reader. - A github.com/emersion/go-imap/v2 (pinned v2.0.0-beta.8) Backend/Session implements 7 real methods (Login, List, Select, Unselect, Status, Fetch, Store) plus a correct no-op Poll; the other 10 of the interface's 18 methods (Create/Delete/Rename/Subscribe/Unsubscribe/Append/Idle/Expunge/ Search/Copy) are explicit stubs returning a clear "not yet implemented" IMAP error - SEARCH/EXPUNGE/COPY/MOVE, IDLE/CONDSTORE, mailbox management, and APPEND are separate follow-up sub-projects per the design doc's agreed ordering with the user. Verified end-to-end with a real go-imap/v2 imapclient (embedded Postgres, no Docker needed) driving Login -> Select -> Fetch -> Store -> List against a message seeded through F1's real SMTP use case, proving true SMTP-write/IMAP-read interop, not just isolated unit tests. Built via 8 sequential tasks under subagent-driven development, each independently reviewed, plus a final whole-branch review. Two real bugs were found and fixed before merge, both exactly the kind unit tests with fakes cannot catch: - Store's UID-set resolution silently no-op'd on dynamic ranges like "UID STORE 1:*" (the common "mark all as read" operation) after an earlier draft bypassed the folder's real message list; restored to resolve against real messages via the same pattern Fetch already used correctly, with tests proving both dynamic ranges and non-UID STORE. - go-imap/v2's server calls Session.Poll() implicitly before the status response of nearly every authenticated command (FETCH/STORE/SEARCH/ APPEND/COPY), not just IDLE as assumed - a hard-stubbed Poll broke every real command through this path; fixed to a correct no-op. - List had zero test coverage despite being committed scope; added unit tests for wildcard/delimiter matching plus a real E2E LIST assertion. Known follow-up, not blocking: a pre-existing test-fixture hygiene gap (hardcoded content_sha256 blob hashes with no cleanup, shared across several Postgres integration test files including one new to this branch) causes local-dev test collisions on repeated runs against a persistent database - invisible to CI (fresh Postgres per run) but worth a cleanup pass.
48 lines
2.4 KiB
Go
48 lines
2.4 KiB
Go
// Package imappresentation adapts github.com/emersion/go-imap/v2's
|
|
// imapserver.Session interface to ImapSessionUseCase (Clean Architecture
|
|
// layer 4 - PLAN.md section 3). This file holds every method NOT
|
|
// implemented for real in this sub-project: each returns a clear IMAP NO
|
|
// error, never a panic, never a silent no-op (see the design doc's
|
|
// "all-or-nothing interface problem" section for why every one of these
|
|
// 18 methods must exist even though only 7 do real work here).
|
|
package imappresentation
|
|
|
|
import (
|
|
"github.com/emersion/go-imap/v2"
|
|
"github.com/emersion/go-imap/v2/imapserver"
|
|
)
|
|
|
|
var errNotYetImplemented = &imap.Error{
|
|
Type: imap.StatusResponseTypeNo,
|
|
Text: "not yet implemented",
|
|
}
|
|
|
|
func (s *session) Create(_ string, _ *imap.CreateOptions) error { return errNotYetImplemented }
|
|
func (s *session) Delete(_ string) error { return errNotYetImplemented }
|
|
func (s *session) Rename(_, _ string, _ *imap.RenameOptions) error { return errNotYetImplemented }
|
|
func (s *session) Subscribe(_ string) error { return errNotYetImplemented }
|
|
func (s *session) Unsubscribe(_ string) error { return errNotYetImplemented }
|
|
func (s *session) Append(_ string, _ imap.LiteralReader, _ *imap.AppendOptions) (*imap.AppendData, error) {
|
|
return nil, errNotYetImplemented
|
|
}
|
|
// Poll is called by imapserver before the status response of nearly every
|
|
// command in the Authenticated/Selected state (see conn.go's c.poll), not
|
|
// just in response to an explicit client IDLE/NOOP - returning an error here
|
|
// would fail every real command (FETCH, STORE, ...), not just polling. This
|
|
// sub-project doesn't push unsolicited EXISTS/EXPUNGE/FETCH updates (no
|
|
// IDLE support - see Idle below), so reporting "no updates" via a nil
|
|
// return is the correct, spec-compliant no-op, not a stub.
|
|
func (s *session) Poll(_ *imapserver.UpdateWriter, _ bool) error { return nil }
|
|
func (s *session) Idle(_ *imapserver.UpdateWriter, _ <-chan struct{}) error {
|
|
return errNotYetImplemented
|
|
}
|
|
func (s *session) Expunge(_ *imapserver.ExpungeWriter, _ *imap.UIDSet) error {
|
|
return errNotYetImplemented
|
|
}
|
|
func (s *session) Search(_ imapserver.NumKind, _ *imap.SearchCriteria, _ *imap.SearchOptions) (*imap.SearchData, error) {
|
|
return nil, errNotYetImplemented
|
|
}
|
|
func (s *session) Copy(_ imap.NumSet, _ string) (*imap.CopyData, error) {
|
|
return nil, errNotYetImplemented
|
|
}
|